Shopping cart example updates #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2016 12:44
|
Good work! Thanks! |
|
Oh, whoops, this is against the wrong branch. It needs to be against create-react-app. Sorry about that. |
|
Huh, I thought it should be against this one since you told me that once Dan is finished this one would be merged into that one. Should I go ahead and create a PR against |
|
Nope, create-react-app replaces the previous one. You should make sure that your branch is rebased against create-react-app, as just opening a PR will include all the prior changes on this branch that we don't want to add yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request I mentioned in #1883. I would appreciate feedback on this. If I have missed anything, please let me know and I will get on it right away.